WIP cosmic-workspace-v2 protocol
#1225
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
workspaces-v2
branch
2 times, most recently
from
8277e78 to
26cd8a2
Compare
|
Oh, and I guess it needs a |
ids1024
force-pushed
the
workspaces-v2
branch
from
26cd8a2 to
8693a0c
Compare
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Feb 20, 2025
Requires pop-os/cosmic-protocols#51, pop-os/cosmic-comp#1225. The new protocol version is a hard requirement, and this will panic without it.
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Feb 20, 2025
Requires pop-os/cosmic-protocols#51, pop-os/cosmic-comp#1225. The new protocol version is a hard requirement, and this will panic without it.
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Feb 21, 2025
Requires pop-os/cosmic-protocols#51, pop-os/cosmic-comp#1225. The new protocol version is a hard requirement, and this will panic without it.
ids1024
force-pushed
the
workspaces-v2
branch
2 times, most recently
from
0dda5bd to
0a631bc
Compare
The protocol states that these should always be sent, but this was not initially sending bitflags if they were empty. That works, but isn't what the protocol states. Not wrapping the bitflag fields in options works well for `Workspace`, but not for `WorkspaceDataInner`.
Already depends on `WorkspaceHandler`, so it can get the handle, and toplevel info uses `WorkspaceHandle`s.
`cosmic-comp` handles `SetTilingState` requests, so it looks like it was incorrectly not advertising this.
ids1024
force-pushed
the
workspaces-v2
branch
from
0a631bc to
58834ca
Compare
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Feb 21, 2025
Requires pop-os/cosmic-protocols#51, pop-os/cosmic-comp#1225. The new protocol version is a hard requirement, and this will panic without it.
This new protocol extends `ext-workspace-v1` with the same additional functionality `cosmic-workspace-v1` provided. Toplevel info and toplevel management are also updated to use ext handles, and there's an image source for ext workspaces. For now, the old protocol is still supported.
ids1024
force-pushed
the
workspaces-v2
branch
from
58834ca to
e4e8680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pop-os/cosmic-protocols#51
(Partly) working, but needs a couple fixes, and update to toplevel-info/toplevel-management (both here and in cctk).