-
Notifications
You must be signed in to change notification settings - Fork 165
Some additional capslock options #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
That looks like 3 options |
You are quite right. I shall update the commit message. |
|
Thanks, and sorry for being pedantic 😅 |
23f4363 to
91c8a6a
Compare
I have no issues with that ;) So yes there are 3 options and the commit message reflects that now. |
added options: - caps:none - caps:return - caps:hyper - caps:menu - caps:numlock - caps:shiftlock - caps:ctrl_shifted_capslock - caps:escape_shifted_capslock - caps:shift - caps:shift_no_cancel Descriptions have been taken from xkeyboard-config(7)
91c8a6a to
4a73be5
Compare
|
Since it hasn't been reviewed I have added a few more options to my PR. I hope nobody minds. |
|
Could I see the screenshot of the UI with updates? |
|
I just pushed a testing branch so CI would build it. It'll be on |
|
Thanks. |
|
Great, thanks! For some reason the branch just wouldn't update for me so the screenshots help. I think it is too many options and the experience is overwhelming. We should try to reduce the number of options if we can. I'd also like to better understand how the following options behave exactly, what happens when you press the first two key combinations and what is the difference between the last three?
|
If we can't do anything about the weird functionality of these extra modes, I think I'd be satisfied slimming the new options down to "Disable" and "Escape, Shift+Caps Lock is regular Caps Lock" (but fix the capitalization on the latter) for this PR and leaving off the rest. |
|
Maybe my attempt to make the PR a bit more meaningful was not the best choice in hindsight. I checked my changes to be sure they at least do what they say. For reference: my keyboard is a mountain 60 with qwerty layout and setup as us-intl with deadkeys.
I will remove the bottom 3 and fix the capitalization. |
0f13f33 to
4a73be5
Compare
|
Would it be possible to fix the order and copy for some of the options while we are on it? Caps Lock options never got a design review before so there are some inconsistencies with how options are presented in Alternate character key and Compose key. The order and copy for the options:
|
For reference: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/blob/master/ChangeLog.md Maybe some checks need to be done before presenting options? Or is that trying to be too flexible? |
|
Ah, that explains it. Yeah if there could be some checks before options are presented, that sounds like a pretty elegant solution to me. I'm not sure what's involved to implement that though. If it's a huge hassle, just commenting those two out with a |




Dear devs,
I use my capslock in a way that is not currently configurable so I created some additions.
so far I just added 2 new options: