Skip to content

Add Tessl change review workflow - #183

Merged
popey merged 5 commits into
mainfrom
chore/activate-tessl-change-review
Aug 4, 2026
Merged

Add Tessl change review workflow#183
popey merged 5 commits into
mainfrom
chore/activate-tessl-change-review

Conversation

@popey

@popey popey commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • add an advisory Tessl change-review workflow for opened, reopened, and ready-for-review PRs
  • allow trusted maintainers to trigger exact-command reruns with @tessl-change-review
  • run analysis and publication in separate least-privilege jobs
  • load executable publisher code only from the trusted default branch
  • reject cross-repository PRs and PR-controlled Tessl configuration before authenticated review execution
  • pin tesslio/setup-tessl to an immutable commit
  • validate Tessl output, including the reviewed head SHA and multiline comment ranges, before publishing one GitHub review
  • cover publisher payload and validation behavior with Node tests in CI

Validation

  • node --check .github/change-review/publish-review.mjs
  • node --test .github/change-review/publish-review.test.mjs
  • workflow YAML parse
  • mocked GitHub review publication
  • python3 -m unittest discover -s tests -v
  • python3 -m py_compile sbom-vm.py generate-test-images.py

The required TESSL_TOKEN Actions secret is configured.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tessl change review:

Reviewed against skills: review-code-legibility, review-test-risk, review-security-risks

review-code-legibility

  • Found 1 issue; overall, the workflow reads clearly but the publisher blurs one accepted comment shape.

review-test-risk

  • Found 2 issues; overall, new executable review automation is not covered by the existing Python-only CI.

review-security-risks

  • Found 2 issues; privileged review publishing trusts PR-generated data too broadly.

To trigger a re-review write a comment that says @tessl-change-review.

Comment thread .github/change-review/publish-review.mjs
Comment thread .github/change-review/publish-review.mjs Outdated
Comment thread .github/change-review/publish-review.mjs Outdated
Comment thread .github/workflows/change-review.yml Outdated
Comment thread .github/workflows/change-review.yml

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/change-review.yml Outdated
Comment thread .github/workflows/change-review.yml Outdated
Comment thread .github/change-review/publish-review.mjs Outdated
Comment thread .github/workflows/change-review.yml Outdated
@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Aug 3, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/change-review/publish-review.test.mjs

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread .github/workflows/change-review.yml

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread .github/workflows/change-review.yml
@popey
popey merged commit 2384f7a into main Aug 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant