Add explicit img disk image support - #184
Conversation
There was a problem hiding this comment.
tessl change review:
Reviewed against skills: review-code-legibility, review-test-risk, review-security-risks
review-code-legibility
- Found 2 issues; overall, the new fallback behavior is understandable but a couple of names/documentation entries blur formats vs suffix fallbacks.
review-test-risk
- Found 1 issue; coverage is mostly aligned, but one assertion is brittle implementation coupling.
review-security-risks
- Found 1 issue;
.imgfallback can now route untrusted input into unbounded decompression.
To trigger a re-review write a comment that says @tessl-change-review.
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
External Linux
|
Summary
.imgas an explicit raw disk-image fallback whenqemu-imgcannot determine a format.imgsuffix are handled correctlyqemu-imgis unavailable.amiand.rawpaths so untrusted.imginputs cannot trigger decompression.imgbehavior and the existing partition/filesystem limitations.imginputValidation
python3 -m unittest discover -s tests -vpython3 -m py_compile sbom-vm.py generate-test-images.py tests/test_image_format.pynode --test .github/change-review/publish-review.test.mjsgit diff --checkCloses #5