Skip to content

Adjust HTML styles for small screens #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

AylenHoz
Copy link
Contributor

@AylenHoz AylenHoz commented Feb 13, 2025

πŸ”— Linked issue

closes #68

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Some HTML styles are not suitable for small screens, such as those on mobile devices:

  • Some padding is too large
  • The stack trace ellipsis is lost on small screens

Solution: Implement styles based on calc and media query to adjust certain styles to the screen size.

Before - After

WhatsApp Image 2025-02-13 at 11 22 47 (1)
WhatsApp Image 2025-02-13 at 11 22 47

πŸ“ Checklist

  • I have read the contribution guide.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@AylenHoz
Copy link
Contributor Author

I don't know why windows test failed if all tests passed

@thetutlage
Copy link
Member

They should pass now if you rebase your branch

@AylenHoz AylenHoz changed the title Adjust HTML styles for smal screens Adjust HTML styles for small screens Feb 13, 2025
Copy link

github-actions bot commented Mar 7, 2025

This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request

@github-actions github-actions bot added the Stale label Mar 7, 2025
@RomainLanz RomainLanz removed the Stale label Mar 7, 2025
Copy link

This pull request has been marked as stale because it has been inactive for more than 21 days. Please reopen if you still intend to submit this pull request

@github-actions github-actions bot added the Stale label Mar 29, 2025
Copy link

github-actions bot commented Apr 3, 2025

This pull request has been automatically closed because it has been inactive for more than 4 weeks. Please reopen if you still intend to submit this pull request

@jereaa
Copy link

jereaa commented Apr 7, 2025

@thetutlage Is there something missing to merge this PR?

@thetutlage thetutlage merged commit 468e628 into poppinss:4.x Apr 9, 2025
14 checks passed
@thetutlage
Copy link
Member

Thanks @AylenHoz for the PR. Sorry for sleeping on it for a long time :)

@thetutlage
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some HTML styles are not suitable for small screens
4 participants