Skip to content

Unpin the generic plink2 build now the AVX2 chrX --hwe fix ships in image 20260818-1 - #50

Merged
joshuamschmidt merged 1 commit into
mainfrom
plink2-hwe-unpin
Aug 18, 2026
Merged

Unpin the generic plink2 build now the AVX2 chrX --hwe fix ships in image 20260818-1#50
joshuamschmidt merged 1 commit into
mainfrom
plink2-hwe-unpin

Conversation

@joshuamschmidt

Copy link
Copy Markdown
Contributor

Unwinds the workaround from #49 now that images#324 has merged and plink:1.9-20250819-PLINK-2.0-20260818-1 (plink2 alpha7 build 18 Aug 2026, carrying the upstream chrX --hwe AVX2 fix) is on the main registry.

  • Bump plink_image in both phase configs to 20260818-1.
  • Remove the PLINK2_FORCE_VARIANT=generic pin from the HWE snplist job, so it returns to the auto-selected (AVX2) build.
  • Point the repro script at the fixed image and make it compare the AVX2 and generic snplists, not just check for the hang.

Verified on the images-dev build of the same image (batch 1135864): both binaries complete and produce identical snplists (496 variants) on the synthetic chrX dataset that previously reproduced the hang.

@Alexander-Stuckey Alexander-Stuckey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joshuamschmidt
joshuamschmidt merged commit 100d2f1 into main Aug 18, 2026
5 checks passed
@joshuamschmidt
joshuamschmidt deleted the plink2-hwe-unpin branch August 18, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants