Skip to content

feat: add above_threshold() #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 21, 2025
Merged

Conversation

rich-iannone
Copy link
Member

@rich-iannone rich-iannone commented May 15, 2025

This PR adds a new above_threshold() method to the Validate class, providing a non-exception alternative to above_threshold(). This enables more flexible programmatic responses to validation results (with a simple boolean return value). The main features of this include (1) checks of 'warning'/'error'/'critical' thresholds (without exceptions), (2) support for checking specific step numbers, and (3) a simple boolean return value for conditional logic.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (aff980a) to head (54d72e7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   99.05%   99.06%           
=======================================
  Files          18       18           
  Lines        4467     4480   +13     
=======================================
+ Hits         4425     4438   +13     
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot temporarily deployed to pr-184 May 15, 2025 00:56 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 15, 2025 01:02 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 15, 2025 01:05 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 15, 2025 01:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 19, 2025 20:30 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 19, 2025 20:33 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 19, 2025 21:03 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 19, 2025 21:08 Destroyed
@github-actions github-actions bot temporarily deployed to pr-184 May 21, 2025 17:16 Destroyed
@rich-iannone rich-iannone changed the title feat: add has_threshold_exceedances() feat: add above_threshold() May 21, 2025
@github-actions github-actions bot temporarily deployed to pr-184 May 21, 2025 17:29 Destroyed
@rich-iannone rich-iannone marked this pull request as ready for review May 21, 2025 18:05
@rich-iannone rich-iannone merged commit ed8dcb2 into main May 21, 2025
8 checks passed
@rich-iannone rich-iannone deleted the feat-has-threshold-exceedances branch May 21, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants