Remove markdown cell rendered preview #10872
Merged
+52
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
nstrayer
previously approved these changes
Dec 3, 2025
Contributor
nstrayer
left a comment
nstrayer
left a comment
There was a problem hiding this comment.
Works wonderful! Just a couple code style suggestions.
Comment on lines
102
to
109
| /* When selected/editing AND no outputs: restore bottom rounding */ | ||
| /* When code cell is selected/editing AND no outputs: restore bottom rounding */ | ||
| .positron-notebook-cell.selected:has(.positron-notebook-cell-outputs.no-outputs) .positron-notebook-editor-container::after, | ||
| .positron-notebook-cell.editing:has(.positron-notebook-cell-outputs.no-outputs) .positron-notebook-editor-container::after, | ||
| .positron-notebook-cell:not(.selected):not(.editing):hover:has(.positron-notebook-cell-outputs.no-outputs) .positron-notebook-editor-container::after { | ||
| .positron-notebook-cell:not(.selected):not(.editing):hover:has(.positron-notebook-cell-outputs.no-outputs) .positron-notebook-editor-container::after, | ||
| /* When markdown cell is in edit mode (no output shown): restore bottom rounding */ | ||
| .positron-notebook-cell.selected:not(:has(.positron-notebook-cell-outputs)) .positron-notebook-editor-container::after, | ||
| .positron-notebook-cell.editing:not(:has(.positron-notebook-cell-outputs)) .positron-notebook-editor-container::after, | ||
| .positron-notebook-cell:not(.selected):not(.editing):hover:not(:has(.positron-notebook-cell-outputs)) .positron-notebook-editor-container::after { |
Contributor
There was a problem hiding this comment.
This is getting a bit crazy. I wonder if using nested syntax may make things a bit easier to reason about.
Contributor
Author
There was a problem hiding this comment.
Agreed this is a bit intense. I'll update this to see if I can make it easier to read!
Comment on lines
36
to
52
| {!editorShown && ( | ||
| <div className='cell-contents positron-notebook-cell-outputs'> | ||
| <div | ||
| className='positron-notebook-markdown-rendered' | ||
| onDoubleClick={() => cell.toggleEditor()} | ||
| > | ||
| { | ||
| markdownString.length > 0 ? | ||
| <Markdown content={markdownString} /> | ||
| : <div className='empty-output-msg'> | ||
| {emptyMarkdownCell} | ||
| {doubleClickToEdit} | ||
| </div> | ||
| } | ||
| </div> | ||
| </div> | ||
| </div> | ||
| )} |
Contributor
There was a problem hiding this comment.
Can we standardize on using just a ternary or the && short circuiting? Small preference for ternary due to risks of truthy eval in js.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10455
This updates markdown cells so that they:
pencilicon in action bar (instead of chevron down) to toggle edit modecheckmarkicon in action bar (instead of chevron up) to toggle view modeAFTER
Screen.Recording.2025-12-01.at.4.10.58.PM.mov
Release Notes
New Features
Bug Fixes
QA Notes
@:positron-notebooks