Skip to content

Set log level to trace when positron-r extension tests are running #10895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionel- merged 3 commits into from
Dec 3, 2025
+9 −2
Merged

Set log level to trace when positron-r extension tests are running #10895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
839b17b
Add missing setup imports
lionel- Dec 3, 2025
f6c53cb
Less confusing log message
lionel- Dec 3, 2025
bb61bbc
Set log level to trace while extension tests are running
lionel- Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/positron-r/src/lsp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export class ArkLsp implements vscode.Disposable {
// With a `.` rather than a `-` so vscode-languageserver can look up related options correctly
const id = 'positron.r';

const message = `Creating ${this._dynState.sessionName} language client for session ${this._metadata.sessionId} on port ${port}`;
const message = `Creating language client ${this._dynState.sessionName} for session ${this._metadata.sessionId} on port ${port}`;

LOGGER.info(message);
outputChannel.appendLine(message);
Expand Down
2 changes: 2 additions & 0 deletions extensions/positron-r/src/test/ark-comm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
*--------------------------------------------------------------------------------------------*/

import './mocha-setup'

import * as assert from 'assert';
import * as vscode from 'vscode';
import * as testKit from './kit';
Expand Down
2 changes: 2 additions & 0 deletions extensions/positron-r/src/test/debugger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
*--------------------------------------------------------------------------------------------*/

import './mocha-setup'

import * as vscode from 'vscode';
import * as assert from 'assert';
import * as testKit from './kit';
Expand Down
5 changes: 4 additions & 1 deletion extensions/positron-r/src/test/mocha-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import * as testKit from './kit';
export let currentTestName: string | undefined;

suiteSetup(async () => {
// Set Ark log level to TRACE for easier debugging of tests
// Set global Positron log level to trace for easier debugging
await vscode.commands.executeCommand('_extensionTests.setLogLevel', 'trace');
Copy link
Contributor Author

@lionel- lionel- Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little command that's only valid when extension tests are running:

positron/src/vs/workbench/api/browser/mainThreadLogService.ts

Line 78 in d46ce10

CommandsRegistry.registerCommand('_extensionTests.setLogLevel', function (accessor: ServicesAccessor, level: string) {

It allows modifying the global vscode log level.


// Set Ark kernel process log level to trace
await vscode.workspace.getConfiguration().update('positron.r.kernel.logLevel', 'trace', vscode.ConfigurationTarget.Global);

// To be safe
Expand Down
Loading