-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle Quarto with Positron #4212
Conversation
@jmcphers, is there any chance the first version of Positron with an embedded copy of Quarto could have an updated copy of Quarto extension built-in with the fix? Or is the fix + update something that will immediately follow (< 24 hours)? |
@coatless It'll definitely be more than 24 hours as this change still needs reviewing and building, and I haven't finished the changes to the Quarto extension yet. In flight, stay tuned! |
Thanks Jonathan, I've rebuilt installers for Mac and Linux with this branch and confirmed they are bundling Quarto 1.5.55 (and understand the extension needs to be updated before it will find them in this new location). I'll rebuild Windows now too just to complete the set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows also bundled Quarto 1.5.55
I was also able to update my PATH to the bundled Quarto and it attempted to use it when previewing a .qmd, but it ran into permission issues compiling the theme on MacOS.
|
@petetronic thanks, I just saw this in my own testing as well this morning! Should be addressed in 6c3c0a6. |
Nice, I confirmed adding the executable flag to the dart binary resolved the error. |
This change bundles the Quarto CLI and all of its requisite tooling (deno, typst, etc.) with Positron, replacing the former Pandoc-only approach. Quarto is currently version-pinned at 1.5.55.
The Quarto bundle is stored in the
quarto
subdirectory of the app root.Addresses #3705.
Important
This change alone is not sufficient to allow the Quarto extension to discover the copy of Quarto bundled in Positron; the Quarto extension's search path is not configurable, so a separate change will need to be made to the Quarto extension to include the Positron app directory in the search path. I'll make that change once this one has landed successfully.
QA Notes
PATH
for Quarto, so if you're feeling brave you can cause it to use this bundled version of Quarto by putting it on yourPATH
.RSTUDIO_PANDOC
points to a folder that contains the pandoc executable, and thatrmarkdown::find_pandoc()
and the "Render R Markdown" command are able to use the new Pandoc.PATH
, so to ensure you're testing against the embedded copy of Quarto and Pandoc in Positron, make sure to remove any other installations of Quarto and Pandoc on yourPATH
(or temporarily modify yourPATH
so they aren't discovered)