Skip to content

Commit

Permalink
Only use root level npm install
Browse files Browse the repository at this point in the history
Remove vscode deps ref
  • Loading branch information
dotNomad committed May 6, 2024
1 parent 9aad040 commit fa6a69e
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 36 deletions.
1 change: 0 additions & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
- run: just npm-install
- run: just check-format

- run: just vscode deps
- run: just vscode lint

- run: just web install
Expand Down
19 changes: 0 additions & 19 deletions extensions/vscode/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,30 +58,11 @@ clean:
rm -rf out
just ./webviews/homeView/clean


# Install dependencies
deps:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
if [ {{ _ci }} = "true" ]; then
npm ci --no-audit --no-fund | sed 's/^/debug: /'
npm --prefix ./webviews/homeView ci --no-audit --no-fund | sed 's/^/debug: /'
else
npm install --no-audit --no-fund | sed 's/^/debug: /'
npm --prefix ./webviews/homeView install --no-audit --no-fund | sed 's/^/debug: /'
fi
just ./webviews/homeView/deps


configure os="$(just ../../os)" arch="$(just ../../arch)":
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just deps

echo "info: checking for compatible binary executable..." 1>&2
binary_executable=$(just ../../executable-path {{ os }} {{ arch }})
if ! [ -f "$binary_executable" ]; then
Expand Down
13 changes: 0 additions & 13 deletions extensions/vscode/webviews/homeView/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,3 @@ clean:
{{ _with_debug }}
rm -rf node_modules


# Install dependencies
deps:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
if [ {{ _ci }} = "true" ]; then
npm ci --no-audit --no-fund | sed 's/^/debug: /'
else
npm install --no-audit --no-fund | sed 's/^/debug: /'
fi
6 changes: 3 additions & 3 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ npm-install:
{{ _with_debug }}
if [ {{ _ci }} = "true" ]; then
npm ci --no-audit --no-fund
npm ci --no-audit --no-fund | sed 's/^/debug: /'
else
npm install --no-audit --no-fund
npm install --no-audit --no-fund | sed 's/^/debug: /'
fi

# staticcheck, vet, and format check
Expand Down Expand Up @@ -215,7 +215,7 @@ name:
basename {{ _cmd }}

package:
package: npm-install
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
Expand Down

0 comments on commit fa6a69e

Please sign in to comment.