Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow requirements.txt and renv.lock files to be excluded from projects #1503

Open
1 of 4 tasks
kgartland-rstudio opened this issue May 2, 2024 · 2 comments
Open
1 of 4 tasks
Labels
enhancement New feature or request vscode
Milestone

Comments

@kgartland-rstudio
Copy link
Collaborator

kgartland-rstudio commented May 2, 2024

You can exclude the requirements.txt and renv.lock files in the Project Files section, subsequent deployments fail when trying to read such files in Connect.


@kgartland-rstudio kgartland-rstudio added enhancement New feature or request vscode labels May 2, 2024
@dotNomad dotNomad removed this from the v1.2.0 milestone Sep 20, 2024
@m-- m-- added this to the v.1.8.0 milestone Dec 10, 2024
@marcosnav marcosnav changed the title Don't allow the requirements.txt file to be excluded for Python projects Don't allow requirements.txt and renv.lock files to be excluded from projects Dec 16, 2024
@dotNomad dotNomad modified the milestones: v1.8.0, v1.10.0 Jan 7, 2025
@dotNomad dotNomad self-assigned this Jan 24, 2025
@dotNomad
Copy link
Collaborator

dotNomad commented Jan 28, 2025

There is a pre-flight check already for the inclusion of the Python.PackageFile:

err := checkRequirementsFile(base, cfg)

@dotNomad
Copy link
Collaborator

Using the same method for checking for package file inclusion for R is not recommended as it has an issue with wildcard inclusions #2563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode
Projects
None yet
Development

No branches or pull requests

4 participants