Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly error when missing required files from bundle #2566

Open
dotNomad opened this issue Jan 29, 2025 · 0 comments
Open

Correctly error when missing required files from bundle #2566

dotNomad opened this issue Jan 29, 2025 · 0 comments
Labels

Comments

@dotNomad
Copy link
Collaborator

dotNomad commented Jan 29, 2025

Currently we do not have helpful errors aside from when the Config.Python.PackageFile file is missing from the included files list, and that one contains a bug: #2563.

A improvement can be made here. One potential option is to insert the checks in between the create and upload bundle operations in internal/publish/bundle.go.

We can utilize the files list inside of the manifest and the Config inside of the defaultPublisher state to check if the package files, and the entrypoint are included with a helpful error.

Related Issues

@dotNomad dotNomad added the epic label Jan 29, 2025
@dotNomad dotNomad changed the title Correctly error when missing files from bundle Correctly error when missing required files from bundle Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant