Handle projects without Python #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
requested review from
dotNomad,
kgartland-rstudio,
sagerb and
tdstein
as code owners
sagerb
previously approved these changes
May 2, 2024
There was a problem hiding this comment.
I have merged this branch into my branch and validated it. I've got a dependency on this, so with my approval (the code looks good as well), I'm going to go ahead and merge it tonight, so I can get mine unblocked.
I had some small bumps in that I was trying to get too smart and just update the configuration file without a python section for a python project. It's great to see that we're smarter than that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR makes the Python packages view handle configurations without Python.
Fixes #1466
Type of Change
Approach
The API endpoint handles cfg.Python being nil and returns an appropriate status code. The Python Packages view uses this to display a separate welcome.
Automated Tests
Added a test for the new case in the API unit tests.
Directions for Reviewers
Open a project that doesn't use Python, and expand the Python Packages treeview.