Send files content to Deployment File webview #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix import path in homeView
Correct onRefreshListMsg
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
sagerb
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the new Deployment Files webview component with content using File Watchers and our new message conduits.
Intent
Resolves #1342
Type of Change
Approach
The approach here is two-fold. The
homeViewsets up:activeConfigChangedlistener that immediately sends the new refreshed include/exclude list, and sets up a file watcher for the currently selected configuration that sends the files again when that configuration changes.We can be a bit more careful about not sending messages, for example, only updating it when the configuration
filesattribute changes, but I've kept it simple here.