Create npm workspaces v2

.github/workflows/home-view-unit-test.yaml

@@ -3,9 +3,6 @@ on: [workflow_call]
 jobs:
   lint:
     runs-on: ubuntu-latest
-    defaults:
-      run:
-        working-directory: extensions/vscode/webviews/homeView
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -14,4 +11,4 @@ jobs:
           cache: "npm"
           cache-dependency-path: "**/package-lock.json"
       - run: npm install
-      - run: npm test
+      - run: npm test --prefix extensions/vscode/webviews/homeView

.github/workflows/lint.yaml

@@ -17,7 +17,6 @@ jobs:
       - run: just npm-install
       - run: just check-format
 
-      - run: just vscode deps
       - run: just vscode lint
 
       - run: just install

.github/workflows/vscode.yaml

@@ -18,6 +18,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: "20"
+      - run: just npm-install
       - id: get-date
         run: echo "date=$(/bin/date -u "+%Y%m%d")" >> $GITHUB_OUTPUT
         shell: bash

extensions/vscode/.vscodeignore

@@ -1,3 +1,8 @@
+# Workaround for https://github.com/microsoft/vscode-vsce/issues/580
+../..
+
+.*
+.*/
 .vscode/**
 .vscode-test/**
 src/**

extensions/vscode/justfile

@@ -58,30 +58,11 @@ clean:
     rm -rf out
     just ./webviews/homeView/clean
 
-
-# Install dependencies
-deps:
-    #!/usr/bin/env bash
-    set -eou pipefail
-    {{ _with_debug }}
-
-    if [ {{ _ci }} = "true" ]; then
-        npm ci --no-audit --no-fund | sed 's/^/debug: /'
-        npm --prefix ./webviews/homeView ci --no-audit --no-fund | sed 's/^/debug: /'
-    else
-        npm install --no-audit --no-fund | sed 's/^/debug: /'
-        npm --prefix ./webviews/homeView install --no-audit --no-fund | sed 's/^/debug: /'
-    fi
-    just ./webviews/homeView/deps
-
-
 configure os="$(just ../../os)" arch="$(just ../../arch)":
     #!/usr/bin/env bash
     set -eou pipefail
     {{ _with_debug }}
 
-    just deps
-
     echo "info: checking for compatible binary executable..." 1>&2
     binary_executable=$(just ../../executable-path {{ os }} {{ arch }})
     if ! [ -f "$binary_executable" ]; then

extensions/vscode/src/views/homeView.ts

@@ -1286,6 +1286,7 @@ export class HomeViewProvider implements WebviewViewProvider, Disposable {
         Uri.joinPath(this.extensionUri, "webviews", "homeView", "dist"),
         Uri.joinPath(
           this.extensionUri,
+          "../..",
           "node_modules",
           "@vscode",
           "codicons",
@@ -1335,6 +1336,7 @@ export class HomeViewProvider implements WebviewViewProvider, Disposable {
     ]);
     // The codicon css (and related tff file) are needing to be loaded for icons
     const codiconsUri = getUri(webview, extensionUri, [
+      "../..",
       "node_modules",
       "@vscode",
       "codicons",

extensions/vscode/tsconfig.json

@@ -17,7 +17,7 @@
     "paths": {
       "src/*": ["./src/*"],
       // workaround for: https://github.com/rollup/rollup/issues/5199
-      "rollup/parseAst": ["./node_modules/rollup/dist/parseAst"]
+      "rollup/parseAst": ["../../node_modules/rollup/dist/parseAst"]
     }
   },
   "exclude": ["node_modules", "webviews", "vitest.config.ts"]

extensions/vscode/webviews/homeView/justfile

@@ -17,16 +17,3 @@ clean:
     {{ _with_debug }}
 
     rm -rf node_modules
-
-
-# Install dependencies
-deps:
-    #!/usr/bin/env bash
-    set -eou pipefail
-    {{ _with_debug }}
-
-    if [ {{ _ci }} = "true" ]; then
-        npm ci --no-audit --no-fund | sed 's/^/debug: /'
-    else
-        npm install --no-audit --no-fund | sed 's/^/debug: /'
-    fi

justfile

@@ -169,9 +169,9 @@ npm-install:
     {{ _with_debug }}
 
     if [ {{ _ci }} = "true" ]; then
-        npm ci --no-audit --no-fund
+        npm ci --no-audit --no-fund | sed 's/^/debug: /'
     else
-        npm install --no-audit --no-fund
+        npm install --no-audit --no-fund | sed 's/^/debug: /'
     fi
 
 # staticcheck, vet, and format check
@@ -206,7 +206,7 @@ name:
 
     basename {{ _cmd }}
 
-package:
+package: npm-install
     #!/usr/bin/env bash
     set -eou pipefail
     {{ _with_debug }}