Separate Python interpreter from inspector and pass selected python environment down through deployment #2556
Conversation
…pdates commands which are unused, but have not yet been removed.
…kage (pydeps). Also updates code to use the new Python Inspector call signature.
…mpact on the python inspector.
…sion-of-python-from-positron
|
Did some double checking due to the failing bats tests:
It looks like the |
…ile is invalid while CLI is also deprecated.
@dotNomad Thanks for diving in. I have just pushed a commit to remove that content type from the test and I have also updated that bogus string I added to be a bit more understandable. We'll see if these changes now help the BAT tests to pass! |
Still failing. I think this is because the requirements file is also being generated for the |
remove bats test from pull-request CI jobs
| @@ -50,3 +57,38 @@ func (s *defaultDependencyScanner) ScanDependencies(base util.AbsolutePath, pyth | |||
| } | |||
| return specs, nil | |||
| } | |||
|
|
|||
| func GetRequirementsFilePath(base util.AbsolutePath) (util.RelativePath, bool, error) { | |||
| filePath := "requirements.txt" | |||
There was a problem hiding this comment.
I would include a comment here to note that this is used in inspection to find a requirements.txt
When reading this I was wondering why it wasn't using the config's package file filename briefly before looking at its usage.
There was a problem hiding this comment.
I've renamed the function to DoesDefaultRequirementsExist as well as adding a comment.
There was a problem hiding this comment.
I did some changes to my machine to test some different cases:
I removed my global Python and this PR still worked perfectly based on the Python interpreter I had selected in the Python VS Code extension.
I also got the correct error if I didn't have the Python extension or Python globally.
I tested changing the selected Python interpreter in Positron and got the expected configurations.
I went through this with a pretty fine tooth comb, both for testing and the review itself. I test on VS Code, Positron, with and without Python environments selected, with an entrypoint at the workspace level and below.
This is a fantastic refactor. I only had one comment about adding a comment where I was a bit confused on the intention. 🚀
| # bats: | ||
| # needs: build | ||
| # secrets: inherit | ||
| # uses: ./.github/workflows/bats.yaml |
There was a problem hiding this comment.
We may want to do this in another PR for easier tracking. Maybe hold on merging this until we make an effort to remove.
There was a problem hiding this comment.
#2558 was opened to remove these so we can solve the conflict with whatever merges first.
…sion-of-python-from-positron
…ttps://github.com/rstudio/publishing-client into sagerb-use-active-version-of-python-from-positron
Intent
This PR includes the functionality required to query and pass on the selected Python interpreter path active within VSCode or Positron and passes that down through the applicable APIs for reference within the agent. The agent then uses the selected Python interpreter when needed.
Resolves #2494
Resolves #2496
Type of Change
Approach
To accomplish having the availability of the Python active interpreter within the agent, I followed the pattern established when we refactored the R interpreter-related functionality.
This involved a number of incremental steps, which have been grouped into related commits:
User Impact
The publisher now recognizes the active python interpreter as selected within Microsoft's Python extension and Posit's Positron IDE. This leads to a more consistent and controllable environment for the users.
Automated Tests
Unit tests have been updated to reflect the changes.
Directions for Reviewers
I have grouped types of changes into individual commits. Reviewing them in that manner should help facilitate a more productive review of the many changes.
The bulk of the functionality change involves creating the new Python interpreter object, extracting this Python interpreter functionality out of the inspection package, and then assessing the impact that those changes had on the other code (especially on the initialize package functionality). In addition, some changes were then needed to extract the correct values from the VSCode/Positron environment and pass them through the API to be available within the API handlers.
The changes involved in this PR are best verified by inspection of our different content types / sample projects. There should be no difference in the detection of Python or not, but the version string will now be consistent with the active version of Python that the user is running (assuming that they are setting this through one of the facilities we support - VSCode Python extension, Positron Python selection or first location found searching the path).
Checklist