Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Troubleshooting renv section #2562

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Docs: Troubleshooting renv section #2562

merged 7 commits into from
Jan 29, 2025

Conversation

marcosnav
Copy link
Collaborator

@marcosnav marcosnav commented Jan 28, 2025

Intent

Add an renv section to the troubleshooting docs page.

Screen Shot 2025-01-28 at 15 50 48

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

Docs

User Impact

Users hitting the "See troubleshooting docs..." link on error messages for renv operations can see more details about how does that work.

Automated Tests

NA

Directions for Reviewers

Read and rewrite as you please

Checklist

Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this to the document. I included several suggestions. I re-wrote a lot of it, but without your initial work I wouldn't have gotten there 🙌

marcosnav and others added 5 commits January 28, 2025 15:22
@marcosnav
Copy link
Collaborator Author

@dotNomad Thanks for the feedback! Definitely much better.

Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but feel free to ignore if you disagree with the change. Thanks for adding this to the doc 🎉

@dotNomad dotNomad added this to the v1.10.0 milestone Jan 28, 2025
Co-authored-by: Jordan Jensen <[email protected]>
@marcosnav marcosnav merged commit 0c29452 into main Jan 29, 2025
13 checks passed
@marcosnav marcosnav deleted the docs-troubleshoot-renv branch January 29, 2025 01:17
@dotNomad dotNomad added the documentation Improvements or additions to documentation label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants