Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #2573

Merged
merged 9 commits into from
Jan 30, 2025
Merged

Upgrade dependencies #2573

merged 9 commits into from
Jan 30, 2025

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Jan 30, 2025

This upgrades several dependencies across our three primary packages - the base package, the VS Code extension, and the home view.

This includes upgrades to:

  • esbuild to bundle the extension
  • prettier and eslint-config-prettier for code formatting and compatibility with ESLint
  • mocha for VS Code testing
  • entities for HTML5 decoding
  • jsdom for testing the home view

A few packages were not upgraded:

  • @types/node wasn't upgraded since VS Code is still using Node 20 via Electron
  • eventsource had some breaking changes. A follow-up issue was made: Upgrade eventsource dependency #2572
  • vite and vitest were not upgraded as they had a migration. That will be a separate PR
  • axios has a TypeScript compilation issue with AxiosRequestConfig typing we do

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

I started with a simple run of npm upgrade then I went through each package available to be upgraded using npm outdated to discovery which had updates.

I then checked the release documentation for each, did an upgrade, and checked the tooling impacted.

Directions for Reviewers

Pull this down and check that CLI tooling like just and tests behave as expected.

Run the extension itself and test the behavior has not been impacted by upgraded dependencies.

Base automatically changed from dotnomad/vscode-ignore to main January 30, 2025 19:02
@dotNomad dotNomad merged commit ae36241 into main Jan 30, 2025
13 checks passed
@dotNomad dotNomad deleted the dotnomad/up-deps branch January 30, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants