Upgrade Vite and Vitest #2574
Merged
Upgrade Vite and Vitest #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
commented
Jan 30, 2025
Comment on lines
-21
to
-27
| css: { | ||
| preprocessorOptions: { | ||
| scss: { | ||
| api: "modern-compiler", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This was removed as this is now the default behavior. https://vite.dev/guide/migration#sass-now-uses-modern-api-by-default
marcosnav
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades dependencies around Vite 6.0:
viteitselfvitestfor testing@vue/tsconfigfor an updated TypeScript Vue configuration file@vitest/coverage-v8for our coverage reportingType of Change
Approach
The approach here was to upgrade all of the dependencies at once and work my way through the Vite 5 -> 6 Migration Guide.
I ran our vitests to make sure those still passed, and ran the extension testing the functionality.
Directions for Reviewers
Pull this down and check that CLI tooling like
justand tests behave as expected.Run the extension itself and test the behavior has not been impacted by upgraded dependencies.