Add ability to update the target guid for a deployment at any time (from the ... menu) #2576
Conversation
…ntact server or not.
| hostConduit.sendMsg({ | ||
| kind: WebviewToHostMessageType.UPDATE_SELECTION_CREDENTIAL_STATE, | ||
| content: { | ||
| state: serverCredential !== undefined ? "true" : "false", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This is always sending back true. Looks like it might be a missing .value on serverCredential.
There was a problem hiding this comment.
I don't understand the purpose of the message sending however. This is checking if the current deployment has a credential, but if we are associating with a different piece of content we could be pointing to an entirely different server. What is this supposed to be catching?
There was a problem hiding this comment.
The purpose is to enable or disable the ability to associate, within the ... menu. I've seen it work, so I'm surprised there is an error there, but I'll check it out. What it implements is that when we do not have a credential for the server, so we couldn't contact the server to patch the deployment file, so it would fail always. So the option isn't offered.
I'll check the logic, like I mentioned, I'm not sure with this how I was seeing the vscode context set correctly per the state, as shown in the screen shots.
There was a problem hiding this comment.
Updated to examine the reference's value rather than the reference itself. Thanks for catching this. The message stayed in place, as my explanation of its purpose above still stands.
extensions/vscode/package.json
Outdated
| @@ -325,6 +330,10 @@ | |||
| "command": "posit.publisher.homeView.showSelectConfigForDeployment", | |||
| "when": "webviewId == 'posit.publisher.homeView' && webviewSection == 'even-easier-deploy-more-menu-matching-configs'" | |||
| }, | |||
| { | |||
| "command": "posit.publisher.homeView.showAssociateDeployment", | |||
| "when": "webviewId == 'posit.publisher.homeView' && webviewSection == 'even-easier-deploy-more-menu-matching-configs' && posit.publish.selection.haveCredentialMatch == 'true'" | |||
There was a problem hiding this comment.
This shows the context menu option while a pre-deployment shows the association link.
We could try to hide it using message passing or we could generalize the label to remove the "with a Different Deployment". 🤔
There was a problem hiding this comment.
I'm not following you. Can you provide a screenshot? I'm looking at
There was a problem hiding this comment.
Yeah that screenshot shows what I'm talking about. We have both "update that previous deployment" available as a link, and the "Associate with a Different Deployment on Connect". The wording is just strange since it isn't associated with any deployment yet. That may be too in the weeds with how this is working though.
There was a problem hiding this comment.
I've added another context state within the extension, which indicates if the actively selected content record is a PreContentRecord or not. This allows the menu item to now be shown only when it has been deployed, which should address the confusion you identified here.
There was a problem hiding this comment.
Thanks for doing that, it is a small thing, but it should make it easier to understand for users.
…ch and some renames.
jonkeane
changed the title
|
I just |
… previous step being removed.
…rom ... menu)
Intent
Add the ability to associate an existing deployment with a different GUID. This simply offers the same capability that we had previously offered ahead of the first deployment within the UX. This option is now always available via the ... menu when a deployment has been selected.
Resolves #2400
Type of Change
Approach
I started by simply exposing existing functionality into the context menu and adding a success notification.
I then realized that the menu item doesn't make any sense if there is no credential match, so I've added and updated a context within the extension that can be used to show or hide the menu item.
New screenshots:
When there are credentials to the server and the active selection has been deployed:
When there are no credentials to the server:
When the active selection has not yet been deployed:
It will show when other errors w/ the config are present:
I also added an informational message when it has completed calling the patch API.
User Impact
New feature!