Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go crypto and net dependencies #2581

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dotNomad
Copy link
Collaborator

This PR upgrades two Go dependencies:

  • golang.org/x/crypto to 0.32.0
  • golang.org/x/net to 0.34.0

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

The approach here was just to use go get <dependency>@latest and then go mod vendor.

Directions for Reviewers

Pull this down and check that CLI tooling like just and tests behave as expected.

Run the extension itself and test the behavior has not been impacted by upgraded dependencies.

`go get golang.org/x/crypto@latest`
`go mod vendor`
`go get golang.org/x/net@latest`
`go mod vendor`
Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I know you mentioned that upgrading the go dependencies wasn't something that you had done before. Do you think it is worth a small update into the CONTRIBUTING.MD file to document the process?

I pulled down the branch and ran the publisher through it's paces, including adding a new credential and deploying to PTD using that credential. I think it is good to merge!

@dotNomad
Copy link
Collaborator Author

I know you mentioned that upgrading the go dependencies wasn't something that you had done before. Do you think it is worth a small update into the CONTRIBUTING.MD file to document the process?

@sagerb great point. I included a section in CONTRIBUTING, let me know if it is clear and we can get this merged in.

@sagerb
Copy link
Collaborator

sagerb commented Feb 20, 2025

@sagerb great point. I included a section in CONTRIBUTING, let me know if it is clear and we can get this merged in.

The updates look great. Lets get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants