Always log deployment URL #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
requested review from
dotNomad,
kgartland-rstudio,
sagerb and
tdstein
as code owners
tdstein
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
When a deployment fails, we aren't telling the user where they can view the failed deployment to troubleshoot it.
This PR causes the CLI to always log the deployment's dashboard URL, even on failure, if it is known (the only case where it's not known is a new deployment where we didn't get to the create new deployment step).
This is also passed to the UI as an attribute on the publishing failure event.
Fixes #601
Fixes #605
Type of Change
Approach
Ensure that
logAppInfois called even on failure (and make it handle failed deployments, and add tests for it).Automated Tests
Added tests for
logAppInfo, which previously didn't have them.Directions for Reviewers
Try to
createorupdatewith failures at various points in the sequence, for example a config file issue that will fail preflight, an unavailable python dependency in requirements.txt, or an app that won't start up. You should see a dashboard URL in the CLI output for all cases exceptcreatewith a preflight failure (in that case, there is no Connect deployment to view).