Skip to content

Conversation

chendaniely
Copy link
Collaborator

@chendaniely chendaniely commented May 5, 2025

fixes the links mentioned in #291 and #290.

The get-started/include/deploy.qmd issue seems to be okay? since it's mainly used as an include so the reference directory is the /get-started/install.qmd directory

@github-actions github-actions bot temporarily deployed to pr-292 May 5, 2025 18:29 Destroyed
@gadenbuie
Copy link
Contributor

Still seeing these issues, are they expected?

2025-05-05T18:18:05.2364476Z [ 74/465] docs/overview.qmd
2025-05-05T18:18:11.2896642Z WARN: Unable to resolve link target: docs/install-create-run.qmd
2025-05-05T18:18:11.2933595Z WARN: Unable to resolve link target: docs/install-create-run.qmd
--
2025-05-05T18:28:49.7339800Z [433/465] templates/stock-app/index.qmd
2025-05-05T18:28:50.4516606Z WARN: Unable to resolve link target: components/inputs/date-range/index.qmd
--
2025-05-05T18:29:08.2443845Z [457/465] get-started/include/why-virtual-env.qmd
2025-05-05T18:29:08.9723711Z WARN: Unable to resolve link target: get-started/include/deploy.qmd

@chendaniely
Copy link
Collaborator Author

I think the only one that's expected should be:

2025-05-05T18:29:08.2443845Z [457/465] get-started/include/why-virtual-env.qmd
2025-05-05T18:29:08.9723711Z WARN: Unable to resolve link target: get-started/include/deploy.qmd

@github-actions github-actions bot temporarily deployed to pr-292 May 5, 2025 19:06 Destroyed
testing to see if this will fix the last warning in #292
try using an absolute path for the include file
@chendaniely
Copy link
Collaborator Author

#293 fixed the last "WARN: Unable to resolve link target" message. It wasn't needed, but if you reference from the root it'll fix the weirdness with include documents in other directories.

@chendaniely chendaniely changed the title fix link changes from #291 chore(URLs): fix link changes from #291 May 5, 2025
@chendaniely chendaniely requested a review from gadenbuie May 5, 2025 20:30
Copy link
Contributor

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gadenbuie gadenbuie merged commit 2a44a6d into main May 5, 2025
1 check passed
@gadenbuie gadenbuie deleted the fix-git-started-link-changes-#291 branch May 5, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants