fix(InputSelectize): Fix InputSelectize set method to clear selections #2024
+72
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the InputSelectize.set method to remove all selected items before setting new selections. Added regression test and example app to verify that selections are properly cleared when setting an empty list. fixes #2013
|
|
Updated the selector for removing selectize items to target only direct children, ensuring correct clearing behavior. Enhanced the test app to display selected values and expanded the test cases to verify selection and clearing of multiple choices.
Imported Inputs, Outputs, and Session from shiny.session and updated the server function signature to include type annotations for improved type safety and clarity.
Refactors the selection logic to only remove items not in the desired set and only add missing items, improving efficiency and correctness when updating selected values in InputSelectize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InputSelectize.setmethod has been enhanced to provide more intelligent option selection. It now carefully examines the currently selected options and compares them with the user's desired selections. When an existing selected option is not part of the user's intended choices, the method automatically selects that option and removes it by pressing the Delete key, ensuring a clean and precise selection process that aligns with the user's expectations.Added regression test and example app to verify that selections are properly cleared when setting an empty list.
fixes #2013