Skip to content

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Feb 21, 2025

When calling python -m rsconnect.environment with invalid arguments, subprocess.check_output returns a JSON object with a single error field. Passing this result directly to MakeEnvironment results in a KeyError since MakeEnvironment requires additional arguments. This change catches the TypeError and surfaces the underlying error message from subprocess.check_output.

Addresses #635

Copy link

github-actions bot commented Feb 21, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4832 3586 74% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/bundle.py 78% 🟢
TOTAL 78% 🟢

updated for commit: 9e41dcc by action🐍

@tdstein tdstein marked this pull request as ready for review February 21, 2025 15:55
@tdstein tdstein merged commit 2a733d8 into main Feb 24, 2025
13 checks passed
@tdstein tdstein deleted the tdstein/635 branch February 24, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants