-
Notifications
You must be signed in to change notification settings - Fork 25
Fix for #676 #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for #676 #677
Conversation
Hi @tuxmaster5000, thanks for the pull request. Can you say a bit more about what scenario you are fixing with this change? I do not see any errors in my local environment when running... uv run --with rsconnect-python==1.26.0 python -m rsconnect.subprocesses.inspect_environment |
When I try to build it as an rpm package. It looks like Fedora 41 is using an modern version of setuptools, because on the EOL version 40 it was not happens. As I understand the documentation of setuptools, when using this option, than all modules must listed by hand. Or don't use this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
It would probably make sense to switch to a tool.setuptools.packages.find
directive so that packages don't have to be manually listed and it's a bit more future-proof.
Also, I suggest in the PR we change https://github.com/posit-dev/rsconnect-python/blob/main/.github/workflows/main.yml#L40 to install in non-editable mode (actually make a dist and then install the dist) so that we can confirm that the changes do actually fix the issue before committing them and that problems like this can be caught in the future.
I have played with find, but this will require an complete reorganisation of the directory structure.
|
should be what we want. If |
I have try it, but this will break the build process. But I don't know why:
|
Ah! when you say "build process" you mean the rpm build process, not the python distribution build process. Building the wheel works as expected with find:
I haven't been building RPMs in years, but that sounds like a bug in
|
I tried to verify things with this test script: https://gist.github.com/amol-/b1ce860fb645a731a8ff4588895041e5 It seems in both cases with
or
it works as expected, because The output of the script for me is
|
Fix for #676