deploy command support for drafts #679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
amol-
commented
Jun 6, 2025
| ["voila", get_dir(join("pip1", "dummy.ipynb"))], | ||
| ] | ||
| ], | ||
| ) |
There was a problem hiding this comment.
This is a bit confusing, but in practice it produces product of args * flag thus testing every deploy command with both flag=True and flag=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Allows to deploy content without activating it.
Type of Change
Approach
New command line option that injects the parameter only when necessary, this way it will be backward compatible with previous API when the parameter is not provided.
Automated Tests
test_deploy_draftruns the command with all possible permutations of content and activate=True/FalseDirections for Reviewers
Currently the deploy doesn't output the url where the draft can be seen, that's planned for a follow-up PR as the two can be done in isolation.
Checklist