Output the preview url in case of drafts #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
Author
|
rebased on main, will fix failures |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
amol-
commented
Jun 11, 2025
| except json.JSONDecodeError: | ||
| logger.debug("--> <invalid JSON>") | ||
| else: | ||
| logger.debug("--> <non-json-response>") |
Collaborator
Author
There was a problem hiding this comment.
Unrelated, but. printing the whole body always lead to the full application home page being dumped on every deploy. I chose to only dump JSON responses as those are the ones usually coming from the APIs and thus that are more valuable when debugging.
Collaborator
There was a problem hiding this comment.
Thank you for this — you're totally right that the whole body is too much in most (many? all?) cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When drafts are available, we need to tell the users where to see the launched content.
Intent
Always oputput as "Direct URL" the url where the currently deployed content is visible.
When it's an active application we show the application url, when it's a draft we output the draft url.
Type of Change
Approach
Expand
RSConnectClientDeployResultwith a new "preview_url" field which has the url where the deployed bundle is served. If the bundle was activated, we will set this toNoneas the content is visibile on theapp_url, if the bundle wasn't activate instead we set this so that it can be printed to user.Automated Tests
test_deploy_drafttest now also tests for the right URL to be printedDirections for Reviewers
This depends on #679Checklist
I think we can avoid updating the CHANGELOG further as #679 already added the concept of deploying drafts as a new feature.