-
Notifications
You must be signed in to change notification settings - Fork 26
feat: --package-manager option #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
I apologize in advance for the driveby comment about naming, but: given that "Package Manager" is one of Posit's products, I worry that calling this argument I don't have an alternative to suggest, just wanted to flag this. Maybe this is fine? |
I think "--package-installer" could work since this is strictly about installation and not other package management operations. PyPI references "package installer":
The Python Packaging guide also generally qualifies "installation" The UV documentation is less precise:
|
in Python specific terms that would probably be the "Package Index": https://pip.pypa.io/en/latest/cli/pip_search/#cmdoption-i I guess that anyone using the PPM would be used to already specify that as the "index" both in |
I don't have a strong opinion, on this side there is a lot of confusion 🤷🏻
|
What about having I share Neal's concern that the unfortunate collision with the Posit product is likely to lead to confusion. If we had to we could recover from that being super explicit if someone puts something other than |
Intent
Allows users to pass a
--package-manager=pip|uv
option to force a specific package manager.By default it's up to the server (and it's backward compatible with server that didn't accept uv)
Closes #707
Type of Change
Approach
The
package_manager
setting is now propagated in theEnvironment
object and can be used by both deploy and write manifest processes.Automated Tests
Added tests for the 3 cases
=uv
=pip
Directions for Reviewers
If in doubt see https://docs.posit.co/connect/user/manifest/#python
Checklist