-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate code base to media-query-list-parser #44
base: master
Are you sure you want to change the base?
Conversation
@yisibl Do you have time in the next few weeks to look at this? We are hoping to wrap up all work for As I said before we totally understand it if you want to go in another direction. |
Thank you for your contribution, I need to chat with my partner and get back to you. |
@yisibl Any news here? |
Thank you for your continued interest, I should have time during the Chinese New Year to carry out my work here. |
Related issues that will likely be fixed by this change :
|
@yisibl Any chance you could give this another look? The parser and underlying tokenizer have been in use now for months in both |
@romainmenke Sorry, too busy with work this month, I'm afraid I'll have time next month! |
That is fine @yisibl :) We really want to move forward with this, given the momentum this feature currently has in browsers. I've created a new plugin based on this PR in the csstools mono repo. Ideally these patches find there way back to this plugin in some form or another after which we can delete the forked plugin and set I've already updated this PR with the latest bug fixes. |
see :
summary :
Our media query list parser has a very large OM and it is a low level API.
Working with this in plain JavaScript is really painful. It is much easier to work with from TypeScript.
To support TypeScript I've added the build config (rollup) from the csstools mono repo.
There are other ways to get a similar result, but this is one I am comfortable with.
This pull request fixes a few issues but mostly focusses on using the new parser and OM to achieve the same outcome.
note :
Totally fine if this is not a direction you want to take with this plugin.
What works for us doesn't necessarily work for you :)