fix(prepare-db): add SQL injection protection to explain_generic#18
Closed
NikolayS wants to merge 2 commits into
Closed
fix(prepare-db): add SQL injection protection to explain_generic#18NikolayS wants to merge 2 commits into
NikolayS wants to merge 2 commits into
Conversation
Add defense-in-depth measures to prevent SQL injection in the explain_generic function: - Validate that query is not empty - Strip trailing semicolons - Reject queries containing multiple statements (semicolons mid-query) - Add security documentation explaining why EXPLAIN is inherently safe (read-only, single statement only) The function remains safe because: 1. EXPLAIN without ANALYZE only plans, never executes 2. PostgreSQL's EXPLAIN only accepts a single statement 3. PL/pgSQL EXECUTE only runs one statement Closes: https://gitlab.com/postgres-ai/postgres_ai/-/issues/70
…tion protection Add comprehensive tests for the SQL injection validation in explain_generic: - Empty query rejection - Null query rejection - Multiple statements (semicolon) rejection - Trailing semicolon handling - Valid query execution - JSON format output Related to: https://gitlab.com/postgres-ai/postgres_ai/-/issues/70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postgres_ai.explain_generic()function to prevent SQL injectionFixes #70
Changes
SQL injection protection (
cli/sql/05.helpers.sql)