Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash/internal assertion on usage of unknown define #101

Closed
povik opened this issue Mar 21, 2025 · 1 comment
Closed

Crash/internal assertion on usage of unknown define #101

povik opened this issue Mar 21, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@povik
Copy link
Owner

povik commented Mar 21, 2025

Usage of an unknown define can crash the tool and trigger an internal assertion.

Example input:

module top;
	wire foo = 3 < `BAR;
endmodule

The AST contains InvalidExpression but gets passed to PopulateNetlist anyway. For some reason compilation->hasIssuedErrors() and/or driver.reportDiagnostics(/* quiet */ false) doesn't catch this.

@povik povik added the bug Something isn't working label Mar 21, 2025
@povik
Copy link
Owner Author

povik commented Mar 31, 2025

Fixed in 9f5b5f4

@povik povik closed this as completed Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant