-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension routes #141
base: main
Are you sure you want to change the base?
Add extension routes #141
Conversation
675c852
to
3f7a33c
Compare
3f7a33c
to
e047376
Compare
86cec5a
to
5d28fa3
Compare
5d28fa3
to
3c76511
Compare
3c76511
to
2c0fe97
Compare
Also added overridable routes for email confirmation
2c0fe97
to
8f49c74
Compare
Hey @danschultzer, sorry to bother you with this but do you intend to pick this up in the near future? Thanks. 🙇 |
Let me see if next week I can go through this again. Last I worked with it I felt this was too fickle, and not very explicit, so I didn't merge it in right away. I'll have to go through the code base again to see exactly what it was that bothered me. What's your use case? It may help me think this PR through. |
Sorry for the delay @danschultzer. I actually ended up solving the issue without needing to use the extension routes, I was having issues getting my |
No problem, great to hear that you could fix the issue with the current Pow release! This PR might not be necessary at all. |
It would be great to have this, not having to create custom controllers for every custom extension route would be a big win! |
5db758b
to
2f0eeae
Compare
This allows for custom extension routes. Custom route for email confirmation will look like this:
I'm thinking that either extension Messages and Routes should be optional, or required on compile time. Right now it'll only fail in runtime, which makes it difficult to know beforehand if something is missing.