Handle all-zero features in density calculation#38
Open
foertsch wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
This PR makes
plot_density()handle all-zero feature weights safely.Summary
calculate_density()againstsum(w) <= 0Why
When the selected feature has all-zero weights, the density calculation currently divides by
sum(w), which becomes zero and produces invalid values downstream.This can cause
plot_density()to fail for zero-expression features instead of returning a valid empty/zero-density plot.What changed
sum(w) <= 0andmap = TRUE, return a zero vector of lengthnrow(x)sum(w) <= 0andmap = FALSE, return a zero-valued density object compatible with the existing downstream codecalculate_density()andplot_density()on an all-zero featureVerification
Tested locally with:
Also verified directly with a synthetic all-zero metadata feature on
SeuratObject::pbmc_small, whereplot_density()now returns aggplot.Related issue
This likely also addresses issue #29 when the reported
Empty rastererror is caused by a zero-valued feature, but I have not reproduced the exact original object from that report.