Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving the hide/show control #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improving the hide/show control #14

wants to merge 2 commits into from

Conversation

jatmika-com
Copy link
Contributor

  • detecting the child nodes
  • rename label to labels, because conflicting with bootstrap label class
  • if zero child then no control to display

@jatmika-com
improving the hide/show control
234e78b 
- detecting the child nodes
- rename label to labels, because conflicting with bootstrap label class
- if zero child then no control to display
@rnpowerconsulting
Copy link
Contributor

It might make more sense to name it something like row-label rather than labels, which is not correct as it is a single label.
Naming it row-label you make it more specific while still avoiding collisions.

@jatmika-com
Copy link
Contributor Author

ah yes, that should do the job.

@jatmika-com
improving class name for the first column element
7652c18 
rename label to row-label, because conflicting with bootstrap label class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jatmika-com @rnpowerconsulting