Skip to content

Do not split transactions when uploading data #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Radiokot
Copy link
Contributor

Fix splitting DB transactions into separate CRUD transactions when uploading data.

Related to #167 (comment)

@Radiokot
Copy link
Contributor Author

Please, check if it builds, as I wasn't able to initialize Gradle for this project in IDEA.
@stevensJourney @simolus3 @kobiebotha

@simolus3
Copy link
Contributor

Please, check if it builds, as I wasn't able to initialize Gradle for this project in IDEA.

I'll check, but could you post the error message if you have gotten any? Also, which OS are you on? We definitely want to make sure everyone can contribute here, so this is something we need to fix.

@Radiokot Radiokot force-pushed the fix/splitting-transactions-on-upload branch from bee9f5b to 654d848 Compare April 23, 2025 10:42
@Radiokot
Copy link
Contributor Author

Thank you. I finally was able to build it in IDEA, had to set Java version to 17 (picked 1.8 by default). The error was missing "org.jetbrains.kotlin.gradle.dsl.JvmTarget.JVM_8" constant in one of the Gradle files.
Now it builds, and I fixed my commit (had syntax error in it).

@simolus3 simolus3 self-assigned this Apr 23, 2025
@simolus3 simolus3 requested a review from stevensJourney April 23, 2025 10:56
Copy link
Contributor

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Happy with the changes here.

@stevensJourney stevensJourney merged commit 16a79c5 into powersync-ja:main Apr 23, 2025
3 checks passed
@Radiokot Radiokot deleted the fix/splitting-transactions-on-upload branch April 23, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants