[WIP] HTTP Client Config #229
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Jul 23, 2025
There was a problem hiding this comment.
This looks nice 👍
One thing I'm wondering about is if we can use this to remove the createClient field in SyncStream and PowerSyncDatabaseImpl (since we now have a proper option for this). I've added those for tests, but it looks like we can now pass the test engine via connection options instead.
(and then as a fallback when the engine option is null, use defaultHttpClient from the companion or just inline the HttpClient call)
simolus3
reviewed
Jul 23, 2025
| /** | ||
| * Extends the default Ktor [HttpClient] configuration with the provided block. | ||
| */ | ||
| public class ExtendedConfig(public val block: HttpClientConfig<*>.() -> Unit) : |
There was a problem hiding this comment.
Also we should remember to make ktor an API dependency in Gradle for this.
(and carefully evaluate the impact that has on the generated Swift headers)
# Conflicts: # core/src/commonIntegrationTest/kotlin/com/powersync/testutils/TestUtils.kt # core/src/commonMain/kotlin/com/powersync/sync/SyncOptions.kt # core/src/commonMain/kotlin/com/powersync/sync/SyncStream.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR allows configuring the Ktor networking client we use for PowerSync connections.
This currently allows for a broad range of configuration, including:
Todos And Open Questions
Verify Websocket logging - this seems to currently be quite limitedWebsockets are no longer used.Gauge the impact of exposing and depending on Ktor in our public
SyncOptionsAPI for SwiftThe addition of this work increased the release XCFramework by 6MB. The header file increased by 6KB.
This is relatively small compared to the current sizes.
Main Branch
This Branch
The ability to use a provided client has been marked as experimental. We could mark this as a delicate API after an initial experimental release.
Demo
The Ktor Logging plugin has been added to the
Hello-PowerSyncdemo. A sample log of the HTTP request headers is belowSwift
The Swift SDK now exposes a limited and controlled subset of plugin functionality by exposing logging PowerSync network requests. powersync-ja/powersync-swift#63