Remove websocket transport, use binary HTTP stream when available #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few issues with websocket streams that are tricky for us to fix. In particular, one issue we've seen is that the sync service sends lines exceeding the default message size for Darwin clients, causing connection resets. Worse, due to this KTOR bug, we can't even customize the frame size, making the WebSocket transport mode fundamentally unstable on Apple platforms.
So, this removes the experimental option for websockets from the SDK. Instead, it adopts the option for binary HTTP streams in the sync service. When both client and sync service are compatible with this, they'll send BSON data over the HTTP stream. That way, we have most of the benefits of the websocket protocol ported to HTTP.
This also configures the socket timeout option to twice the usual frequency used by the sync service, allowing us to detect broken HTTP connections.
Closes #208.