-
Notifications
You must be signed in to change notification settings - Fork 19
Supabase error handling #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/commonMain/kotlin/com/powersync/db/driver/SingleConnectionPool.kt # integrations/sqldelight/build.gradle.kts
0f5d4ed
to
99d5f1a
Compare
stevensJourney
previously approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement to the current implementation! I left some minor wording suggestions, but this LGTM.
...rations/supabase/src/commonMain/kotlin/com/powersync/connector/supabase/SupabaseConnector.kt
Outdated
Show resolved
Hide resolved
stevensJourney
previously approved these changes
Oct 1, 2025
stevensJourney
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the supabase connector to make it
open
and allow a few methods to be customized:open
method.open
method.This is to address this reported issue where a user wants to report errors to Crashlytics. At the moment, because the connector is final and catches fatal Postgres exceptions by (apart from a logger, essentially silently) deleting local writes, that would be tricky to detect (it doesn't even show up as an upload error in the sync status).
To clean up some top-level directories, this also moves the Supabase connector into the
integrations/
folder. The maven artifact id is not affected by this because of agradle.properties
file with aPOM_ARTIFACT_ID
entry.