Skip to content

Conversation

simolus3
Copy link
Contributor

This expands the supabase connector to make it open and allow a few methods to be customized:

  • Uploading individual crud rows has been extracted into an open method.
  • Handling errors is also an open method.

This is to address this reported issue where a user wants to report errors to Crashlytics. At the moment, because the connector is final and catches fatal Postgres exceptions by (apart from a logger, essentially silently) deleting local writes, that would be tricky to detect (it doesn't even show up as an upload error in the sync status).

To clean up some top-level directories, this also moves the Supabase connector into the integrations/ folder. The maven artifact id is not affected by this because of a gradle.properties file with a POM_ARTIFACT_ID entry.

Base automatically changed from test-pool to main September 30, 2025 10:04
@simolus3 simolus3 force-pushed the supabase-error-handling branch from 0f5d4ed to 99d5f1a Compare September 30, 2025 11:22
@simolus3 simolus3 marked this pull request as ready for review September 30, 2025 14:02
stevensJourney
stevensJourney previously approved these changes Oct 1, 2025
Copy link
Contributor

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement to the current implementation! I left some minor wording suggestions, but this LGTM.

stevensJourney
stevensJourney previously approved these changes Oct 1, 2025
@simolus3 simolus3 merged commit ee9984a into main Oct 2, 2025
8 checks passed
@simolus3 simolus3 deleted the supabase-error-handling branch October 2, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants