[Fix] Watched queries with large commits #26
Merged
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently it was discovered that watched queries could fail when large data volumes were involved.
This behaviour was traced down to the SQLite commit hooks firing before the commit has completed executing. The commit operation takes longer for larger data volumes, which causes watched queries to trigger before the data is available.
This removes the use of the SQLite commit hook for flushing table changes. Tables changes are instead flushed when the write lock is freed. This is slightly less optimal, but is guaranteed for all data to be available before triggering table change notifications.