Fix crashes when binding or reading blob values #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
ArrayBuffer
as a blob value, we used to pass the underlying data pointer of the buffer to theshared_ptr
constructor. This makes the value take ownership of the underlying contents, which is not correct! The JS engine keeps ownership of data, we should clone instead. Binding the buffer causes a duplicate free when the JS engine eventually collects garbage, crashing the app.SQLITE_BLOB
values,memcpy
was called on an uninitializeduint8_t *
. Writing into the uninitialized pointer is undefined behavior (crashing the app is a best-case scenario here).