Conversation
nicoonoclaste
commented
May 28, 2019
nicoonoclaste
commented
- Avoid function calls in default arguments (it has surprising behaviour: the call is only evaluated once)
- Comply with PEP8 code style.
- Remove unused imports and variables.
- Use a uniform import order
- Use trailing commas where useful
pathunstrom
left a comment
pathunstrom
left a comment
There was a problem hiding this comment.
Blocking this for now, will discuss tomorrow.
examples/targets.py
Outdated
| import ppb | ||
| from ppb import Vector | ||
| from ppb import keycodes | ||
| from ppb import keycodes, Vector |
There was a problem hiding this comment.
Prefer one per import per line
There was a problem hiding this comment.
FYI, there were already places which had multiple imports per line, and in ppb-vector too.
There was a problem hiding this comment.
Yeah, she and I kinda disagree on that.
There was a problem hiding this comment.
OK, so then @pathunstrom, can we agree to disagree, instead of expecting contributors to conform with a styleguide that only exists in your head, that the codebase doesn't comply with, and giving them imperative-mode feedback without explanations?
There was a problem hiding this comment.
PS: I just realised the tone might be wrong there; to clarify, I wasn't annoyed at you, though I felt it was important to provide feedback on that being frustrating & why (not necessarily just for me, but also for other contributors), esp. since that's not the first time it happens.
nicoonoclaste
force-pushed
the
minor-fixes
branch
from
577db0b to
a787ab7
Compare
Per Piper's request.
3 participants
