Avoid incorrect warning about title font color and menu background color being equal or similar | #473 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the .set_menu after .set_font to avoid _check_title_color before a title font color is set.
DKNorad
changed the title
|
Thanks, I'll merge today |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 97.22% 97.24% +0.01%
==========================================
Files 49 49
Lines 12422 12436 +14
==========================================
+ Hits 12077 12093 +16
+ Misses 345 343 -2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the
self._menubar.set_menu(self)afterself._menubar.set_font()to avoid running_check_title_color()inmenubar.pybefore a title font color is set.