Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong bytes per sample in TrackBass #6039

Merged
merged 1 commit into from
Oct 31, 2023

Fix wrong bytes per sample in TrackBass

9756229
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix wrong bytes per sample in TrackBass #6039

Fix wrong bytes per sample in TrackBass
9756229
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Linux, MultiThreaded, Release) failed Oct 31, 2023 in 1s

Test Results (Linux, MultiThreaded, Release) ❌

Tests failed

❌ TestResults-Linux-MultiThreaded-Release.trx

3100 tests were completed in 201s with 3025 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Framework.Tests.Audio.BassAudioMixerTest 18✔️ 1❌ 5s

❌ osu.Framework.Tests.Audio.BassAudioMixerTest

✔️ TestAddedToGlobalMixerByDefault
✔️ TestAddEffect
✔️ TestCannotBeRemovedFromGlobalMixer
❌ TestChannelDoesNotPlayIfReachedEndAndMovedMixers
	TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
✔️ TestChannelDoesNotPlayIfReachedEndAndSeekedBackwards
✔️ TestChannelMovedToGlobalMixerAfterDispose
✔️ TestChannelRetainsPlayingStateWhenMovedBetweenMixers
✔️ TestFreedChannelRemovedFromDefault
✔️ TestInsertEffect
✔️ TestMixerInitialised
✔️ TestMovedToGlobalMixerWhenRemovedFromMixer
✔️ TestMoveEffect
✔️ TestPlayPauseStop
✔️ TestRemoveEffect
✔️ TestReplaceEffect
✔️ TestSampleChannelReferenceLostWhenSampleChannelIsDisposed
✔️ TestTrackIsMovedBetweenMixers
✔️ TestTrackReferenceLostWhenTrackIsDisposed
✔️ TestVirtualTrackCanBeAddedAndRemoved

Annotations

Check failure on line 217 in osu.Framework/Audio/Track/TrackBass.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, MultiThreaded, Release)

osu.Framework.Tests.Audio.BassAudioMixerTest ► TestChannelDoesNotPlayIfReachedEndAndMovedMixers

Failed test found in:
  TestResults-Linux-MultiThreaded-Release.trx
Error:
  TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
Raw output
TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
--TearDown
   at osu.Framework.Audio.Track.TrackBass.UpdateState() in /home/runner/work/osu-framework/osu-framework/osu.Framework/Audio/Track/TrackBass.cs:line 217
   at osu.Framework.Audio.AudioComponent.Update() in /home/runner/work/osu-framework/osu-framework/osu.Framework/Audio/AudioComponent.cs:line 86
   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren() in /home/runner/work/osu-framework/osu-framework/osu.Framework/Audio/AudioCollectionManager.cs:line 54
   at osu.Framework.Audio.AudioComponent.Update() in /home/runner/work/osu-framework/osu-framework/osu.Framework/Audio/AudioComponent.cs:line 88
   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren() in /home/runner/work/osu-framework/osu-framework/osu.Framework/Audio/AudioCollectionManager.cs:line 54
   at osu.Framework.Audio.AudioComponent.Update() in /home/runner/work/osu-framework/osu-framework/osu.Framework/Audio/AudioComponent.cs:line 88
   at osu.Framework.Tests.Audio.BassTestComponents.Dispose() in /home/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Audio/BassTestComponents.cs:line 96
   at osu.Framework.Tests.Audio.BassAudioMixerTest.Teardown() in /home/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Audio/BassAudioMixerTest.cs:line 40