Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PerformanceOverlay public #6357

Closed
wants to merge 3 commits into from

Conversation

frenzibyte
Copy link
Member

Useful for keeping the performance overlay open at a low scale so it doesn't bother me when I'm playing while waiting for a random stutter to hit.

@frenzibyte frenzibyte added the next-release Pull requests which are almost there label Aug 12, 2024
@peppy
Copy link
Sponsor Member

peppy commented Aug 12, 2024

envvar maybe better? unless there's precedence for doing it this way.

@frenzibyte
Copy link
Member Author

frenzibyte commented Aug 12, 2024

Making it a setting also allows changing the scale back if I want to be able to see the perfomance monitor at full scale again (since there's gonna be a slider in settings for this), but if you think that's too much I can make it an envvar.

@peppy
Copy link
Sponsor Member

peppy commented Aug 12, 2024

i dunno, doesn't feel like something i'd expect to sit in settings. Personall I'd prefer an osu-side hacky way of doing this using Game.ChildrenOfType<PerformanceOverlay>().

@peppy
Copy link
Sponsor Member

peppy commented Aug 12, 2024

Or looking at things from a different perspective, adding a display of GC collections on the collapsed view would also work fine (stable kinda did this for long frames).

@frenzibyte
Copy link
Member Author

i dunno, doesn't feel like something i'd expect to sit in settings. Personall I'd prefer an osu-side hacky way of doing this using Game.ChildrenOfType<PerformanceOverlay>().

I can do that but I need to make PerformanceOverlay public, it's internal currently.

Or looking at things from a different perspective, adding a display of GC collections on the collapsed view would also work fine (stable kinda did this for long frames).

Sure but I'm not sure I can come up with something right now, I don't have any ideas on how I want to display it.

@frenzibyte frenzibyte changed the title Add config setting to change scale of performance overlay Make PerformanceOverlay public Aug 12, 2024
@peppy
Copy link
Sponsor Member

peppy commented Aug 15, 2024

As discussed IRL, let's not do this for now (have provided other ways to view GC collections).

I'd want to see this executed by one of the following:

  • Making the design collapse better
  • Adding a third more compact display mode which still shows GCs as they happen
  • Just show GCs on the existing compact mode
  • Limiting the maximum scale the overlay displays at (currently it just scales up forever)

@peppy peppy closed this Aug 15, 2024
@frenzibyte frenzibyte deleted the performance-overlay-scale branch August 15, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release Pull requests which are almost there size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants