-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PerformanceOverlay
public
#6357
Conversation
envvar maybe better? unless there's precedence for doing it this way. |
Making it a setting also allows changing the scale back if I want to be able to see the perfomance monitor at full scale again (since there's gonna be a slider in settings for this), but if you think that's too much I can make it an envvar. |
i dunno, doesn't feel like something i'd expect to sit in settings. Personall I'd prefer an osu-side hacky way of doing this using |
Or looking at things from a different perspective, adding a display of GC collections on the collapsed view would also work fine (stable kinda did this for long frames). |
I can do that but I need to make
Sure but I'm not sure I can come up with something right now, I don't have any ideas on how I want to display it. |
PerformanceOverlay
public
As discussed IRL, let's not do this for now (have provided other ways to view GC collections). I'd want to see this executed by one of the following:
|
Useful for keeping the performance overlay open at a low scale so it doesn't bother me when I'm playing while waiting for a random stutter to hit.