Reduce runtime of autogen #1266
Open
+431
−332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
autogen_faster
branch
from
a152f62 to
473edd8
Compare
hanno-becker
force-pushed
the
autogen_faster
branch
2 times, most recently
from
2cf4003 to
4f6565c
Compare
mkannwischer
requested changes
Nov 4, 2025
scripts/autogen
Outdated
| gen_preprocessor_comments() | ||
| high_level_status("Generated preprocessor comments") | ||
|
|
||
| finalize() |
There was a problem hiding this comment.
Why is there no args.dry_run here?
I don't understand how the linting works. I thought it will fail in the finalize step, but that does not seem to be the case.
There was a problem hiding this comment.
Argh, thank you for catching this. This is crucial.
Instead of writing updated content to FS immediately, redirect all file read/write operations through an internal in-memory cache, and flush to memory only at the end. This also has the side-benefit that intermediate steps in dry-run don't need to produce the final file, so we can format only once in the end. Formatting performance is improved by processing multiple files at once using clang-format. A file scheduled to be deleted is signified by a `None` content. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
- Abort early if a file does not contain any citations. - Manually wrap long lines rather than invoking clang-format. Signed-off-by: Hanno Becker <[email protected]>
Manually wrap long comments, and reuse condition parser object. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
autogen_faster
branch
from
4f6565c to
62df8ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various smaller improvements to speed up
scripts/autogen.On my local machine: 40s -> 16s