autogen/simpasm: Add support for Intel syntax #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends scripts/simpasm to support the emission of x86_64 assembly in Intel syntax via --x86-64-syntax intel. The CI is extended to exercise this on an x86_64 runner and run the full tests afterwards. This can be useful for consuming libraries wishing to use a different syntax than what mlkem-native uses. A similar approach may be usable in the future to add assembly suitable for the Windows assembler. Signed-off-by: Hanno Becker <[email protected]>
mkannwischer
approved these changes
Nov 5, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Nice, thanks @hanno-becker! Tested on my x86 machine - works like a charm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends scripts/simpasm to support the emission of x86_64 assembly in Intel syntax via --x86-64-syntax intel.
The CI is extended to exercise this on an x86_64 runner and run the full tests afterwards.
This can be useful for consuming libraries wishing to use a different syntax than what mlkem-native uses. A similar approach may be usable in the future to add assembly suitable for the Windows assembler.