Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary appending of null bytes in FlValue as length is known #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove unnecessary appending of null bytes in FlValue as length is known #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/charset_converter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ class CharsetConverter {
static Future<String> decode(String charset, Uint8List data) async {
final result = await _channel.invokeMethod('decode', {
"charset": charset,
// A bit silly, but GLib string (gchar *) is the same as C's, the end of the string must be '\0'.
// We are bad at C so we handle it here.
"data": Platform.isLinux ? Uint8List.fromList([...data, 0]) : data,
"data": data,
});

if (result == null) {
Expand Down