-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cov 658 translations #324
base: develop
Are you sure you want to change the base?
Conversation
moh-moola
commented
Jul 22, 2020
•
edited
Loading
edited
- Add a language screen
- Add PO language files
c9a535f
to
d26cb4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions around the translations, seems like we've got a lot of strings missing. Otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On some of the spot checks, I noticed that the wrong translations were being used. Please double check every translation carefully against the spreadsheet
], | ||
"Please use numbers from list. Do you feel very hot or cold? Are you sweating or shivering? When you touch your forehead, does it feel hot?\n\nReply": [ | ||
null, | ||
"Voel jy baie warm of koud? Sweet of bewe jy? Wanneer jy aan jou voorkop vat, voel dit warm?\n\nAntwoord" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have translations for the catchall
error, so for the catchall error it should be simple enough to concatenate the error translation with the question translation.
We'll just need to be careful around character counts.
37e1a9d
to
f21f292
Compare